allow one-directional outflow to LevelBoundary #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
SouthEndMusic
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a model from @d2hydro (d2hydro/lhm-ribasim#5 (comment)).
FractionalFlow, FlowBoundary and TabulatedRatingCurve should be able to flow out into a LevelBoundary. This is slightly odd since in these cases the level of the level boundary does not matter, since the flow is always into the LevelBoundary as determined by the other side. So using a Terminal might make more sense there.
Still, validation shouldn't block this since you may want a single boundary node that connects to multiple node types, some directed like this, some with resistance for which you need a level.